os/bluestore: speedup the performance of multi-replication flow by switc… #11844
Conversation
|
@voidbag Sure, I will leave you a message when this pr is merged. |
|
@liewegas, Any more comment? |
|
Can you please fix your |
xiexingguo
changed the title
|
@xiexingguo and Sage, thank you.I meet some issue with git, and will update the signed.-off-by asap |
|
git commit --amend is probably all you need to do |
|
@liewegas Thanks, I updated and Signed-off-by happy now :) |
|
Given that there's no associated issue, it would be great to have something explaining this change somewhere |
|
@dmick Thank you for reminding. I just added some information in the begnning of this conversation. |
|
@liupan1111 can you put the explanation in the git commit itself? |
switching the callback order in bluestore. In Bluestore ack callback and commit callback are queued one by one in the function "BlueStore;:_txc_finish_kv". Therefore, just only one callback is needed to call, in order to improve performance. We do this by switching the callback order in bluestore, and the callback work can be done in sub_op_modify_commit and doesn't need to do it again in sub_op_modify_applied. Signed-off-by: Pan Liu <pan.liu@istuary.com>
|
@liewegas It is done now. |
|
retest this please |
|
@voidbag, this PR is merged, Please update your code. Thanks. |
|
@liupan1111, |
…hing the callback order in bluestore.
In Bluestore ack callback and commit callback are queued one by one in the function "BlueStore;:_txc_finish_kv". Therefore, just only one callback is needed to call, in order to improve performance. We do this by switching the callback order in bluestore, and the callback work can be done in sub_op_modify_commit and doesn't need to do it again in sub_op_modify_applied.
Signed-off-by: Pan Liu pan.liu@istuary.com