ceph-disk: Handle custom mount options for non-default-named clusters #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mount the disk temporally and read the cluster uuid, then load the right config file. Unmount and pass the custom options to move_mount. Signed-off-by: Kai Zhang <zakir.exe@gmail.com>
| if mount_options is not None: | ||
| mount_options = "".join(mount_options.split()) | ||
|
|
||
| mount_options = None | ||
| path = mount(dev=dev, fstype=fstype, options=mount_options) |
There was a problem hiding this comment.
Maybe it's no good to use default options in some cases :(
liewegas
added a commit
that referenced
this pull request
Dec 14, 2016
rados: move readwrite test out of thrash matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mount the disk temporally and read the cluster uuid, then load the right config file.
Unmount and pass the custom options to move_mount.
Signed-off-by: Kai Zhang zakir.exe@gmail.com