tests: fix osd-scrub-repair.sh #12072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzafman
force-pushed
the
wip-test-17830
branch
from
45afedb
to
e0ed147
Compare
|
There be only 1 more bug before this pull request can be merged: http://tracker.ceph.com/issues/17966 There is only the 1 failure on the last Jenkins run. |
dzafman
force-pushed
the
wip-test-17830
branch
from
e0ed147
to
8f217ad
Compare
dzafman
changed the title
|
Ready to be reviewed and merged. |
|
When running the test from within an emacs buffer, [loic@rex001 build]$ stty -a | head -1 | sed -e 's/.*columns \([0-9]*\).*/\1/' 0 [loic@rex001 build]$ stty -a speed 38400 baud; rows 0; columns 0; line = 0; intr = ^C; quit = ^\; erase = ; kill = ; eof = ^D; eol = ; eol2 = ; swtch = ; start = ^Q; stop = ^S; susp = ^Z; rprnt = ^R; werase = ^W; lnext = ^V; flush = ^O; min = 1; time = 0; -parenb -parodd cs8 -hupcl -cstopb cread -clocal -crtscts -ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl ixon -ixoff -iuclc -ixany -imaxbel -iutf8 opost -olcuc -ocrnl -onlcr -onocr -onlret -ofill -ofdel nl0 cr0 tab0 bs0 vt0 ff0 isig icanon iexten -echo echoe echok -echonl -noflsh -xcase -tostop -echoprt echoctl echoke [loic@rex001 build]$ and the test fail with /home/loic/ceph-ubuntu-14.04-loic/src/test/osd/osd-scrub-repair.sh:1811: TEST_corrupt_scrub_erasure: diff -y -W 0 td/osd-scrub-repair/checkcsjson td/osd-scrub-repair/csjson diff: invalid width '0' diff: Try 'diff --help' for more information. /home/loic/ceph-ubuntu-14.04-loic/src/test/osd/osd-scrub-repair.sh:1811: TEST_corrupt_scrub_erasure: test no = yes /home/loic/ceph-ubuntu-14.04-loic/src/test/osd/osd-scrub-repair.sh:1811: TEST_corrupt_scrub_erasure: return 1 |
|
Now running while : ; do echo -n . ; ctest -R osd-scrub-repair.sh >& ../out || break ; sleep 1 ; done and I'll let it run until tomorrow morning. while : ; do echo -n . ; rm -fr build ; ./run-make-check.sh >& out || break ; sleep 10 ; done |
tchaikov
reviewed
Nov 21, 2016
| if (hinfo->get_total_chunk_size() != pos) { | ||
| dout(0) << "_scan_list " << poid << " got incorrect size on read" << dendl; | ||
| if (hinfo->get_chunk_hash(get_parent()->whoami_shard().shard) != h.digest()) { | ||
| dout(0) << "_scan_list " << poid << " got incorrect hash on read" << dendl; |
There was a problem hiding this comment.
this commit looks good to me.
Caused by: 1e95f2c Signed-off-by: David Zafman <dzafman@redhat.com>
Signed-off-by: David Zafman <dzafman@redhat.com>
dzafman
force-pushed
the
wip-test-17830
branch
from
8f217ad
to
b9c85c4
Compare
dzafman
changed the title
tchaikov
approved these changes
Nov 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.