os/bluestore: avoid resharding if the last shard size fall below shar… #12447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somnathr
reviewed
Dec 12, 2016
| << " extents" << dendl; | ||
| if (!force && | ||
| (len > g_conf->bluestore_extent_map_shard_max_size || | ||
| len < g_conf->bluestore_extent_map_shard_min_size)) { | ||
| ( n == shards.end() && len < g_conf->bluestore_extent_map_shard_min_size) //do not apply shard_min_size to the last shard since this might trigger permanent resharding |
There was a problem hiding this comment.
Can you put the comment on top probably as it is invisible here because of the column limit ?
Since we want to exclude last shard , won't it be ( n != shards.end()) ?
ifed01
force-pushed
the
wip-bluestore-fix-reshard2
branch
from
e0ccf6f
to
c8a567b
Compare
|
@somnathr. Yeah it has to be != shard.end() indeed. Updated. Thanks. |
|
LGTM |
liewegas
approved these changes
Dec 12, 2016
|
LGTM also |
xiexingguo
approved these changes
Dec 13, 2016
|
[ OK ] ObjectStore/StoreTest.TooManyBlobsTest/2 (75167 ms) [----------] Global test environment tear-down |
…d min size Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
ifed01
force-pushed
the
wip-bluestore-fix-reshard2
branch
from
c8a567b
to
3530606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d min size. This might cause permanent resharding since the last shard tend to be small.
Signed-off-by: Igor Fedotov ifedotov@mirantis.com