common: ping existing admin socket before unlink (emperor) #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will just cherry-pick -x when the time comes |
mon: OSDMonitor: don't crash if formatter is invalid during osd crush dump
When a daemon initializes it tries to create an admin socket and unlinks any pre-existing file, regardless. If such a file is in use, it causes the existing daemon to loose its admin socket. The AdminSocketClient::ping is implemented to probe an existing socket, using the "0" message. The AdminSocket::bind_and_listen function is modified to call ping() on when it finds existing file. It unlinks the file only if the ping fails. http://tracker.ceph.com/issues/7188 fixes: #7188 Backport: emperor, dumpling Reviewed-by: Sage Weil <sage@inktank.com> Signed-off-by: Loic Dachary <loic@dachary.org> (cherry picked from commit 4560078)
|
@ircolle suggested it's now ready to backport |
ghost
reopened this
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a daemon initializes it tries to create an admin socket and unlinks
any pre-existing file, regardless. If such a file is in use, it causes
the existing daemon to loose its admin socket.
The AdminSocketClient::ping is implemented to probe an existing socket,
using the "0" message. The AdminSocket::bind_and_listen function is
modified to call ping() on when it finds existing file. It unlinks the
file only if the ping fails.
http://tracker.ceph.com/issues/7188 fixes: #7188
Backport: emperor, dumpling
Reviewed-by: Sage Weil sage@inktank.com
Signed-off-by: Loic Dachary loic@dachary.org
(cherry picked from commit 4560078)