Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: ping existing admin socket before unlink (dumpling) #1248

Closed
wants to merge 1 commit into from
Closed

common: ping existing admin socket before unlink (dumpling) #1248

wants to merge 1 commit into from

Commits on Feb 15, 2014

  1. common: ping existing admin socket before unlink 

    When a daemon initializes it tries to create an admin socket and unlinks
any pre-existing file, regardless. If such a file is in use, it causes
the existing daemon to loose its admin socket.

The AdminSocketClient::ping is implemented to probe an existing socket,
using the "0" message. The AdminSocket::bind_and_listen function is
modified to call ping() on when it finds existing file. It unlinks the
file only if the ping fails.

http://tracker.ceph.com/issues/7188 fixes: #7188

Backport: emperor, dumpling
Reviewed-by: Sage Weil <sage@inktank.com>
Signed-off-by: Loic Dachary <loic@dachary.org>
(cherry picked from commit 4560078)
    Loic Dachary committed Feb 15, 2014
    Copy the full SHA
    28468c4 View commit details
    Browse the repository at this point in the history