os/bluestore/BlueFS: fix reclaim_blocks #12725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com>
We need to return all extents to the caller. The current code fails to assign *offset so it appears like a single extent from the start of the device, which is very wrong. Fixes: http://tracker.ceph.com/issues/18368 Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
changed the title
xiexingguo
approved these changes
Jan 3, 2017
|
lgtm also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to return all extents to the caller. The current code
fails to assign *offset so it appears like a single extent from
the start of the device, which is very wrong.