New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore/BlueFS: fix reclaim_blocks #12725

Merged
merged 2 commits into from Jan 9, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Dec 30, 2016

We need to return all extents to the caller. The current code
fails to assign *offset so it appears like a single extent from
the start of the device, which is very wrong.

liewegas added some commits Dec 30, 2016

os/bluestore/bluestore_types: operator<< for AllocExtent
Signed-off-by: Sage Weil <sage@redhat.com>
os/bluestore/BlueFS: fix reclaim_blocks
We need to return all extents to the caller.  The current code
fails to assign *offset so it appears like a single extent from
the start of the device, which is very wrong.

Fixes: http://tracker.ceph.com/issues/18368
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas changed the title from mon/OSDMonitor: set last_force_op_resend on overlay pool too to os/bluestore/BlueFS: fix reclaim_blocks Dec 30, 2016

@varadakari

Looks good to me.

@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jan 3, 2017

Member

lgtm also

Member

xiexingguo commented Jan 3, 2017

lgtm also

@liewegas liewegas merged commit 93d7a21 into ceph:master Jan 9, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment