osdc/Objecter: resend pg commands on interval change #12869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying to get make check to run. |
|
retest this please |
athanatos
force-pushed
the
wip-18358
branch
5 times, most recently
from
e77648b
to
06d3d19
Compare
liewegas
reviewed
Jan 12, 2017
| @@ -1296,7 +1296,7 @@ void Objecter::handle_osd_map(MOSDMap *m) | |||
| p != need_resend_linger.end(); ++p) { | |||
| LingerOp *op = *p; | |||
| if (!op->session) { | |||
| _calc_target(&op->target, &op->last_force_resend); | |||
| _calc_target(&op->target); | |||
There was a problem hiding this comment.
this hunk goes in the previous patch?
liewegas
changed the title
liewegas
approved these changes
Jan 12, 2017
It's always passed along with op_target_t, this seems simpler. Signed-off-by: Samuel Just <sjust@redhat.com>
mark_lost_unfound* are now async since the rework, so we need the Objecter to be able to resend on interval change. This is preferable to somehow requeueing the Command because they don't use the normal op queue. Fixes: http://tracker.ceph.com/issues/18358 Signed-off-by: Samuel Just <sjust@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.