New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osdc/Objecter: resend pg commands on interval change #12869

Merged
merged 2 commits into from Jan 12, 2017

Conversation

Projects
None yet
2 participants
@athanatos
Contributor

athanatos commented Jan 11, 2017

No description provided.

@athanatos athanatos added this to the kraken milestone Jan 11, 2017

@athanatos

This comment has been minimized.

Contributor

athanatos commented Jan 11, 2017

Trying to get make check to run.

@athanatos

This comment has been minimized.

Contributor

athanatos commented Jan 11, 2017

retest this please

@athanatos athanatos changed the title from DNM: Wip 18358 to Wip 18358 Jan 12, 2017

@athanatos athanatos requested a review from liewegas Jan 12, 2017

@@ -1296,7 +1296,7 @@ void Objecter::handle_osd_map(MOSDMap *m)
p != need_resend_linger.end(); ++p) {
LingerOp *op = *p;
if (!op->session) {
_calc_target(&op->target, &op->last_force_resend);
_calc_target(&op->target);

This comment has been minimized.

@liewegas

liewegas Jan 12, 2017

Member

this hunk goes in the previous patch?

This comment has been minimized.

@athanatos

athanatos Jan 12, 2017

Contributor

ah, yeah

@liewegas liewegas changed the title from Wip 18358 to osdc/Objecter: resend pg commands on interval change Jan 12, 2017

@liewegas

lgtm aside from that one hunk

athanatos added some commits Jan 10, 2017

Objecter: fold last_force_resend into op_target_t
It's always passed along with op_target_t, this seems simpler.

Signed-off-by: Samuel Just <sjust@redhat.com>
Objecter: resend pg commands on interval change
mark_lost_unfound* are now async since the rework, so we need
the Objecter to be able to resend on interval change.  This
is preferable to somehow requeueing the Command because they
don't use the normal op queue.

Fixes: http://tracker.ceph.com/issues/18358
Signed-off-by: Samuel Just <sjust@redhat.com>

@athanatos athanatos merged commit 1753abc into ceph:master Jan 12, 2017

1 of 3 checks passed

Unmodifed Submodules checking if PR has modified submodules
Details
default Build triggered. sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment