Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: Support for shared locking in ManagedLock #12886

Merged
merged 1 commit into from Jan 18, 2017

Conversation

Projects
None yet
2 participants
@rjfd
Copy link
Contributor

rjfd commented Jan 11, 2017

Signed-off-by: Ricardo Dias rdias@suse.com

@rjfd rjfd added feature rbd labels Jan 11, 2017

@rjfd rjfd force-pushed the rjfd:wip-shared-managed-lock branch from 18c9b0d to 2e37266 Jan 11, 2017

@dillaman dillaman changed the title rbd: Support for shared locking in ManagedLock librbd: Support for shared locking in ManagedLock Jan 11, 2017

@dillaman

This comment has been minimized.

Copy link
Contributor

dillaman commented Jan 13, 2017

Note: the GetLockerRequest state machine will need to be updated after #12922 is merged

@dillaman

This comment has been minimized.

Copy link
Contributor

dillaman commented Jan 13, 2017

@rjfd nit: in your commit messages, you should use a "librbd"-prefix when making changes to librbd. The "rbd"-prefix is mostly used for the rbd CLI tool.

@@ -29,13 +29,19 @@ class ManagedLock {
public:
static const std::string WATCHER_LOCK_TAG;

enum Mode {

This comment has been minimized.

Copy link
@dillaman

dillaman Jan 13, 2017

Contributor

Nit: can you move this to managed_lock/Types.h? I have assigned myself a tracker ticket to remove all unnecessary dependencies to this templated class in order to clean up the unit tests.

@rjfd rjfd force-pushed the rjfd:wip-shared-managed-lock branch from 2e37266 to 9785c00 Jan 16, 2017

@rjfd

This comment has been minimized.

Copy link
Contributor Author

rjfd commented Jan 16, 2017

@dillaman addressed the comments and pushed new changes

@dillaman
Copy link
Contributor

dillaman left a comment

lgtm

@dillaman

This comment has been minimized.

Copy link
Contributor

dillaman commented Jan 17, 2017

@rjfd Rebase is now required

librbd: Support for shared locking in ManagedLock
Signed-off-by: Ricardo Dias <rdias@suse.com>

@rjfd rjfd force-pushed the rjfd:wip-shared-managed-lock branch from 9785c00 to 5769c6b Jan 17, 2017

@rjfd

This comment has been minimized.

Copy link
Contributor Author

rjfd commented Jan 17, 2017

@dillaman rebase done

@dillaman dillaman merged commit dacf4da into ceph:master Jan 18, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@rjfd rjfd deleted the rjfd:wip-shared-managed-lock branch Jan 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.