librbd: Support for shared locking in ManagedLock #12886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjfd
force-pushed
the
wip-shared-managed-lock
branch
from
18c9b0d
to
2e37266
Compare
dillaman
changed the title
|
Note: the GetLockerRequest state machine will need to be updated after #12922 is merged |
|
@rjfd nit: in your commit messages, you should use a "librbd"-prefix when making changes to librbd. The "rbd"-prefix is mostly used for the rbd CLI tool. |
dillaman
reviewed
Jan 13, 2017
| @@ -29,13 +29,19 @@ class ManagedLock { | |||
| public: | |||
| static const std::string WATCHER_LOCK_TAG; | |||
|
|
|||
| enum Mode { | |||
There was a problem hiding this comment.
Nit: can you move this to managed_lock/Types.h? I have assigned myself a tracker ticket to remove all unnecessary dependencies to this templated class in order to clean up the unit tests.
rjfd
force-pushed
the
wip-shared-managed-lock
branch
from
2e37266
to
9785c00
Compare
|
@dillaman addressed the comments and pushed new changes |
|
@rjfd Rebase is now required |
Signed-off-by: Ricardo Dias <rdias@suse.com>
rjfd
force-pushed
the
wip-shared-managed-lock
branch
from
9785c00
to
5769c6b
Compare
|
@dillaman rebase done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ricardo Dias rdias@suse.com