Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: extend OMAP_GETKEYS and GETVALS to include a 'more' output field #12950

Merged
merged 9 commits into from Jan 22, 2017

Commits on Jan 19, 2017

  1. osd/PrimaryLogPG: tell client if we truncate results

    If we truncate the results of the omap read commands,
    provide a flag so that the caller knows there is more
    to be read.  We don't need to provide the name of the
    next key because the interface is defined as
    "start_after" (not "start_with"), allowing them to use
    the last key they received.
    
    Signed-off-by: Sage Weil <sage@redhat.com>
    liewegas committed Jan 19, 2017
    Copy the full SHA
    d6dcf41 View commit details
    Browse the repository at this point in the history
  2. osdc/Objecter: add pmore argument to omap_get_{keys,vals}

    Note that the MDS callers have new #warnings indicating that they
    are not providing the pmore argument and are thus broken.  (They
    were already broken.)
    
    Signed-off-by: Sage Weil <sage@redhat.com>
    liewegas committed Jan 19, 2017
    Copy the full SHA
    b6aef08 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2017

  1. osdc/Objecter: infer ptruncated on old OSDs via max_entries

    If we do not get an explicit 'more' value from the OSD, infer it by
    checking whether we got the max requested entries.  On old OSDs, which
    don't enforce a limit, this will work.  On new OSDs, we will get the
    explicit result.
    
    Signed-off-by: Sage Weil <sage@redhat.com>
    liewegas committed Jan 20, 2017
    Copy the full SHA
    cfa6f79 View commit details
    Browse the repository at this point in the history
  2. librados: add omap_get_{keys,vals}2 with pmore output arg

    Expose public methods that include a new output argument to indicate
    whether there are more keys to fetch or not.
    
    Mark the old interfaces deprecated.
    
    Signed-off-by: Sage Weil <sage@redhat.com>
    liewegas committed Jan 20, 2017
    Copy the full SHA
    fbebd83 View commit details
    Browse the repository at this point in the history
  3. ceph_test_rados_*: use new omap methods

    Make these tests pass nullptr for pmore.  This codifies our
    assumption that the OSD limits are high enough.
    
    Signed-off-by: Sage Weil <sage@redhat.com>
    liewegas committed Jan 20, 2017
    Copy the full SHA
    b9f4194 View commit details
    Browse the repository at this point in the history
  4. rados: omap bench: pass null for pmore for omap fetch

    Assume OSD limits are high enough for us.
    
    Signed-off-by: Sage Weil <sage@redhat.com>
    liewegas committed Jan 20, 2017
    Copy the full SHA
    35671ce View commit details
    Browse the repository at this point in the history
  5. ceph_test_rados: pass nullptr for pmore for omap fetch

    Assume OSD limits are hugh enough.
    
    Signed-off-by: Sage Weil <sage@redhat.com>
    liewegas committed Jan 20, 2017
    Copy the full SHA
    faec324 View commit details
    Browse the repository at this point in the history
  6. rados: use bare omap_get_keys op

    This handles the client-side looping on 'more' if the OSD limits
    the response size.
    
    Signed-off-by: Sage Weil <sage@redhat.com>
    liewegas committed Jan 20, 2017
    Copy the full SHA
    2d9cfad View commit details
    Browse the repository at this point in the history
  7. PendingReleaseNotes: mention old clients vs new OSDs

    Signed-off-by: Sage Weil <sage@redhat.com>
    liewegas committed Jan 20, 2017
    Copy the full SHA
    1f150f8 View commit details
    Browse the repository at this point in the history