Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/bluestore: fix reclaim_blocks and clean up Allocator interface #12963

Merged
merged 8 commits into from Jan 19, 2017
Merged

os/bluestore: fix reclaim_blocks and clean up Allocator interface #12963

merged 8 commits into from Jan 19, 2017

Commits on Jan 18, 2017

  1. os/bluestore: manage vector from ExtentList 

    ExtentList was previous relying the caller to preallocate/size the
vector to be large enough for the worst case allocation of extents,
and keeping it's own manual count of the extent list size.  Instead,
manage that from ExtentList, and remove the preallocation from the
callers.

Fixes: http://tracker.ceph.com/issues/18573
Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Jan 18, 2017
    Copy the full SHA
    5297858 View commit details
    Browse the repository at this point in the history

  2. os/bluestore: return blocks allocated from allocate() 

    Instead of having a separate output argument with the number of
blocks allocated, just return it via the return value.  Simplifies
the calling convention.

Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Jan 18, 2017
    Copy the full SHA
    5ab0343 View commit details
    Browse the repository at this point in the history

  3. os/bluestore: drop useless count arg to allocate 

    The vector<> has a size.

Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Jan 18, 2017
    Copy the full SHA
    f012481 View commit details
    Browse the repository at this point in the history

  4. os/bluestore/Allocator: drop unused and goofy release_extents 

    Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Jan 18, 2017
    Copy the full SHA
    efabd17 View commit details
    Browse the repository at this point in the history

  5. os/bluestore: prealloc/reserve extent vector for common alloc path 

    No need to worry about the gift/reclaim path--those are very rare.

Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Jan 18, 2017
    Copy the full SHA
    b3fca67 View commit details
    Browse the repository at this point in the history

  6. unitest_bit_alloc, unittest_alloc: fixes 

    Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Jan 18, 2017
    Copy the full SHA
    ebf7106 View commit details
    Browse the repository at this point in the history

  7. os/bluestore/BlueFS: handle failure to reclaim blocks without crashing 

    We shouldn't fail to reclaim space in general, but if we do, do not treat
it as a fatal error.  Log loudly.

Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Jan 18, 2017
    Copy the full SHA
    6dc1bcd View commit details
    Browse the repository at this point in the history

  8. os/bluestore/BlueFS: dump allocator freelist on failure in reclaim_bl… 

    …ocks

Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Jan 18, 2017
    Copy the full SHA
    15ff485 View commit details
    Browse the repository at this point in the history