kraken: rgw: Use decoded URI when verifying TempURL #12986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Werkov I think this needs to be targeted to master. After it is merged to master it can be backported to kraken, etc. |
smithfarm
changed the title
|
@Werkov After the master PR is merged, please re-do this as a cherry-pick using |
|
@Werkov The master commit has been merged. Please go ahead as described in the previous comment. |
Instead of calliing url_decode directly, we reuse s->decoded_uri that is initialized in RGWREST::preprocess(). Fixes: http://tracker.ceph.com/issues/18590 Signed-off-by: Michal Koutný <mkoutny@suse.com> (cherry picked from commit 4e1318f)
Werkov
force-pushed
the
rgw-fix-tempurl-url-encoding
branch
from
2a95399
to
bfc058d
Compare
smithfarm
changed the title
|
@smithfarm: this PR looks like a Kraken backport. Should we change the title and update the |
smithfarm
changed the title
|
@rzarzynski Thanks; done! |
|
This PR passed an RGW suite at http://tracker.ceph.com/issues/19009#note-18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18627