Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kraken: rgw: fix handling RGWUserInfo::system in RGWHandler_REST_SWIFT. #13006

Merged
merged 1 commit into from Jan 23, 2017

Conversation

rzarzynski
Copy link
Contributor

This is the kraken backport of PR #12865.

CC: @yehudasa, @cbodley.

@rzarzynski rzarzynski added this to the kraken milestone Jan 19, 2017
@rzarzynski rzarzynski force-pushed the wip-rgw-18476-kraken branch 2 times, most recently from 33c8113 to 5fe9357 Compare January 23, 2017 16:59
@rzarzynski
Copy link
Contributor Author

@yehudasa: rebased.

Copy link
Member

@yehudasa yehudasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Before this patch the flag was wrongly handled in the Swift API
implementation. In rare conditions this might result in setting
req_state::system_request.

This may happen only if both of those conditions are fulfilled:
 * RadosGW is running in a multi-site configuration (at least
   one user with the system flag turned on is present),
 * the "rgw_swift_account_in_url" configurable has been switched
   to true. The value is false by default and our documentation
   doesn't actually mention about the option.

The issue doesn't affect Jewel nor any previous release.

Fixes: http://tracker.ceph.com/issues/18476
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
(cherry picked from commit 8dac933)
@rzarzynski rzarzynski merged commit e4d348b into ceph:kraken Jan 23, 2017
@rzarzynski rzarzynski deleted the wip-rgw-18476-kraken branch January 24, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants