New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: fix min_alloc_size at mkfs time #13192

Merged
merged 4 commits into from Feb 2, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Jan 30, 2017

No description provided.

@liewegas liewegas added the bluestore label Jan 30, 2017

derr << __func__ << " failed to read min_min_alloc_size" << dendl;
return -EIO;
}
t->set(PREFIX_SUPER, "min_alloc_size", bl);

This comment has been minimized.

@ifed01

ifed01 Jan 31, 2017

Contributor

Don't see any read of that parameter, looks like min_alloc_size in uninitialized if mkfs is bypassed.

@ifed01

ifed01 Jan 31, 2017

Contributor

Don't see any read of that parameter, looks like min_alloc_size in uninitialized if mkfs is bypassed.

liewegas added some commits Jan 31, 2017

os/bluestore: EIO if we can't read some existing super keys
Signed-off-by: Sage Weil <sage@redhat.com>
os/bluestore: add ondisk format version info to super section
Note the version of the ondisk format and the oldest version that is
allowed to read us.

Signed-off-by: Sage Weil <sage@redhat.com>
os/bluestore: fix min_alloc_size at mkfs time
It is an ongoing challenge to allow min_alloc_size to be varied on
an existing bluestore instance, and the code paths are not well
tested.  Avoid the complexity entirely by fixing min_alloc_size at
mkfs time.

Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Jan 31, 2017

Member

fixed, cleaned up, tested trivial upgrade w/ vstart

Member

liewegas commented Jan 31, 2017

fixed, cleaned up, tested trivial upgrade w/ vstart

Show outdated Hide outdated src/os/bluestore/BlueStore.cc
os/bluestore: decode min_alloc_size into temp var
Defend against future changes to min_alloc_size.

Signed-off-by: Sage Weil <sage@redhat.com>
@ifed01

ifed01 approved these changes Jan 31, 2017

@liewegas liewegas added the needs-qa label Jan 31, 2017

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Jan 31, 2017

Member

retest this please

Member

liewegas commented Jan 31, 2017

retest this please

@liewegas liewegas merged commit 6e72005 into ceph:master Feb 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the liewegas:wip-bluestore-min-alloc-size branch Feb 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment