Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: do not send ENXIO on misdirected op by default #13206

Merged
merged 1 commit into from Feb 3, 2017

Conversation

Projects
None yet
4 participants
@liewegas
Copy link
Member

liewegas commented Jan 31, 2017

In practice this tends to get bubbled up the stack as an error on
the caller, and they usually do not handle it properly. For example,
with librbd, this turns into EIO and break the VM.

Instead, this will manifest as a hung op on the client. That is
also not ideal, but given that the root cause here is generally a
bug, it's not clear what else would be better.

We already log an error in the cluster log, so teuthology runs will
continue to fail.

Workaround for http://tracker.ceph.com/issues/18751

osd: do not send ENXIO on misdirected op by default
In practice this tends to get bubbled up the stack as an error on
the caller, and they usually do not handle it properly.  For example,
with librbd, this turns into EIO and break the VM.

Instead, this will manifest as a hung op on the client.  That is
also not ideal, but given that the root cause here is generally a
bug, it's not clear what else would be better.

We already log an error in the cluster log, so teuthology runs will
continue to fail.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas requested review from dillaman and jdurgin Jan 31, 2017

@dillaman
Copy link
Contributor

dillaman left a comment

lgtm

@liewegas liewegas added the needs-qa label Feb 1, 2017

@yuriw yuriw merged commit c18061c into ceph:master Feb 3, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.