kraken: rgw: Swift API: spurious newline after http body causes weird errors #13224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
changed the title
|
@yehudasa This passed an RGW suite at http://tracker.ceph.com/issues/19009#note-8 Please review/approve if you agree it can be merged. |
|
@yehudasa This PR passed another RGW suite at http://tracker.ceph.com/issues/19009#note-18 Waiting for review. |
The current code emits a newline after swift errors, but fails to account for it when it calculates 'content-length'. This results in some clients (go github.com/ncw/swift) producing complaints about the unsolicited newline such as this, Unsolicited response received on idle HTTP channel starting with "\n"; err=<nil> This logic eliminates the newline on flush. This makes the content length calculation correct and eliminates the stray newline. There was already existing separator logic in the rgw plain formatter that can emit a newline at the correct point. It had been checking "len" to decide if previous data had been emitted, but that's reset to 0 by flush(). So, this logic adds a new per-instance variable to separately track state that it emitted a previous item (and should emit a newline). Fixes: http://tracker.ceph.com/issues/18473 Signed-off-by: Marcus Watts <mwatts@redhat.com> Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> (cherry picked from commit 5f229d6)
smithfarm
force-pushed
the
wip-18780-kraken
branch
from
6208aaf
to
d1ec595
Compare
|
Could someone please review this PR. |
oritwas
approved these changes
Jun 20, 2017
|
jenkins test this please |
1 similar comment
|
jenkins test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18780