src/common/config_opts.h: Clean up config_opts.h #13372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring the OSD(s) ``down`` otherwise clients I/O would be blocked for long time. Current ``mon_osd_report_timeout`` values is 900 seconds. It's too long. This pull request will change current value to 300. IMHO 300 is still long a bit. Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>
… considering the OSD(s) ``down`` otherwise clients I/O would be blocked for long time." This reverts commit a443f5b.
Current default value of ``mon_osd_report_timeout`` is 900. With this value, if the MON is considering some OSD(s) down, clients I/O could be potentially blocked for 900 seconds. This PR is to propose lowering this default value to 300 seconds. IMHO it is still a bit long. Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current default value of
mon_osd_report_timeoutis 900. With this value, if the MON is considering some OSD(s) down, clients I/O could be potentially blocked for 900 seconds.This PR is to propose lowering this default value to 300 seconds.
IMHO it is still a bit long.
Signed-off-by: Shinobu Kinjo shinobu@redhat.com