Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/FuseStore: include <functional> header in src/os/FuseStore.h for gcc 7.x #13454

Merged
merged 1 commit into from Feb 16, 2017

Conversation

joscollin
Copy link
Member

@joscollin joscollin commented Feb 16, 2017

This is done as per the Header Dependency Changes in gcc 7.
https://gcc.gnu.org/gcc-7/porting_to.html

Signed-off-by: Jos Collin jcollin@redhat.com

@tchaikov
Copy link
Contributor

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it would be "os/FuseStore:".

@badone badone self-assigned this Feb 16, 2017
@joscollin joscollin changed the title include <functional> header in src/os/FuseStore.h for gcc 7.x os/FuseStore: include <functional> header in src/os/FuseStore.h for gcc 7.x Feb 16, 2017
…cc 7.x

This is done as per the Header Dependency Changes in gcc 7.
https://gcc.gnu.org/gcc-7/porting_to.html

Signed-off-by: Jos Collin <jcollin@redhat.com>
Copy link
Contributor

@badone badone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joscollin
Copy link
Member Author

Done

@badone badone merged commit 5d1014f into ceph:master Feb 16, 2017
@joscollin joscollin deleted the joscollin-fix branch April 11, 2017 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants