New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-dencoder: enable bluestore types #13595

merged 2 commits into from Feb 23, 2017


None yet
3 participants

tchaikov commented Feb 22, 2017

No description provided.

@tchaikov tchaikov added the tests label Feb 22, 2017

os/bluestore: fix bluestore_blob_t::generate_test_instances()
add extends before marking unused ranges, otherwise add_unused()
asserts if (offset + len < blob_len)
this method is supposed to be used by ceph-dencoder, but
bluestore_blob_t's codec is quite different. we are not testing its
encoding in ceph-dencoder at this moment.

Signed-off-by: Kefu Chai <>

tchaikov referenced this pull request Feb 23, 2017

os/bluestore: version shard and spanning blob buffers, not each blob
Instead of versioning every blob encoding, and adding a full byte
per blob, instead version the entire shard or spanning blob
chunk, since they are always encoded together.

We overload the 'features' argument here to pass through a
struct_v.  This is slightly abusing an argument that is normally
used for feature bits, but only slightly.

Signed-off-by: Sage Weil <>

@tchaikov tchaikov requested review from liewegas and wjwithagen Feb 23, 2017

ceph-dencoder: s/WITH_LIBAIO/HAVE_LIBAIO/
* s/WITH_LIBAIO/HAVE_LIBAIO/: as HAVE_LIBAIO is used to detect if libaio
  is installed and is exposed in the acconfig.h.
* do not test bluestore_blob_t with ceph-dencoder, as it repurposes the
  "feature" parameter for struct_v.

Signed-off-by: Willem Jan Withagen <>
Signed-off-by: Kefu Chai <>

@liewegas liewegas added the bluestore label Feb 23, 2017

@liewegas liewegas merged commit 8ff8f0f into ceph:master Feb 23, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Unmodifed Submodules submodules for project are unmodified
default Build finished.

@tchaikov tchaikov deleted the tchaikov:wip-enable-bluestore-ceph-dencoder branch Feb 23, 2017


This comment has been minimized.

Show comment
Hide comment

wjwithagen Feb 23, 2017


Nice work, thanx.


wjwithagen commented Feb 23, 2017

Nice work, thanx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment