ceph-dencoder: enable bluestore types #13595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add extends before marking unused ranges, otherwise add_unused() asserts if (offset + len < blob_len) this method is supposed to be used by ceph-dencoder, but bluestore_blob_t's codec is quite different. we are not testing its encoding in ceph-dencoder at this moment. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-enable-bluestore-ceph-dencoder
branch
from
a842d08
to
21de2ca
Compare
tchaikov
referenced
this pull request
Feb 23, 2017
Instead of versioning every blob encoding, and adding a full byte per blob, instead version the entire shard or spanning blob chunk, since they are always encoded together. We overload the 'features' argument here to pass through a struct_v. This is slightly abusing an argument that is normally used for feature bits, but only slightly. Signed-off-by: Sage Weil <sage@redhat.com>
tchaikov
force-pushed
the
wip-enable-bluestore-ceph-dencoder
branch
from
21de2ca
to
d3fdcb0
Compare
* s/WITH_LIBAIO/HAVE_LIBAIO/: as HAVE_LIBAIO is used to detect if libaio is installed and is exposed in the acconfig.h. * do not test bluestore_blob_t with ceph-dencoder, as it repurposes the "feature" parameter for struct_v. Signed-off-by: Willem Jan Withagen <wjw@digiware.nl> Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-enable-bluestore-ceph-dencoder
branch
from
d3fdcb0
to
a3b8e0a
Compare
liewegas
approved these changes
Feb 23, 2017
|
@tchaikov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.