Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
rbd-nbd: warn when kernel parameters are ignored #13694
changed the title from
rbd-nbd: prompt message when input nbds_max, and nbd module already l…
rbd-nbd: warn when kernel parameters are ignored
Mar 1, 2017
Sorry, I should have done this earlier. Anyway, when I tested this manually, I noticed that the message may repeat several times if you have several devices already mapped:
This is because when a devpath is not specified, rbd-nbd iterates over /dev/nbdX starting from 0, until open_device succeeds.
Do we want to improve this? I think we can call
@liupan1111 There is "`" character at the end of "Signed-off-by" line in the log message for your first comment. You might want to clean this. Otherwise LGTM.
BTW, in case you are not aware, you can use
Mar 11, 2017
@trociny @dillaman use this place to ask you a question:
Could you give me some help? Thanks!
@liupan1111 I think this is because the main thread is blocked on a kernel call:
And attach to a particular rbd-nbd thread (using id from LWP column)
This way you will need to attach to every thread you are interested in. And don't attach to the main thread! Not sure how helpful it is in your case.
I suppose we could workaround this creating a separate thread for