hammer: osdc/Objecter: If osd full, it should pause read op which w/ rwordered flag #13784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinobu-x
changed the title
shinobu-x
force-pushed
the
wip-19139-hammer
branch
5 times, most recently
from
d609dab
to
5100c5e
Compare
|
retest this please |
shinobu-x
force-pushed
the
wip-19139-hammer
branch
3 times, most recently
from
ac3d3a1
to
ffa2f84
Compare
shinobu-x
force-pushed
the
wip-19139-hammer
branch
from
ffa2f84
to
83af8cd
Compare
shinobu-x
force-pushed
the
wip-19139-hammer
branch
2 times, most recently
from
f14e8b8
to
34e2485
Compare
FULL_TRY = try to do the op; ENOSPC if it results in a net increase is space. client must cope. FULL_FORCE = do the op even if it consumes space. The MDS will use this. We should restrict this based on the OSD cap (* vs w, probably). Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 95055e7)
shinobu-x
force-pushed
the
wip-19139-hammer
branch
from
c039b27
to
64658ac
Compare
resend writes after pool loses full flag Signed-off-by: xinxin shu <xinxin.shu@intel.com> (cherry picked from commit dbcf2e4) Conflicts: src/osdc/Objecter.cc src/osdc/Objecter.h
shinobu-x
force-pushed
the
wip-19139-hammer
branch
from
64658ac
to
2b0646a
Compare
shinobu-x
changed the title
|
retest this please |
1 similar comment
|
retest this please |
amitkumar50
reviewed
Aug 18, 2017
| @@ -410,6 +410,8 @@ enum { | |||
| pool uses pool snaps */ | |||
| CEPH_OSD_FLAG_REDIRECTED = 0x200000, /* op has been redirected */ | |||
| CEPH_OSD_FLAG_KNOWN_REDIR = 0x400000, /* redirect bit is authoritative */ | |||
| CEPH_OSD_FLAG_FULL_TRY = 0x800000, /* try op despite full flag */ | |||
There was a problem hiding this comment.
@shinobu-x (NIT) Please try to use title of PR < 50 characters for future PRs.
https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#title-of-pull-requests-and-title-of-commits
| @@ -898,7 +898,8 @@ bool Objecter::ms_dispatch(Message *m) | |||
|
|
|||
| void Objecter::_scan_requests(OSDSession *s, | |||
| bool force_resend, | |||
| bool force_resend_writes, | |||
| bool cluster_full, | |||
| map<int64_t, bool> *pool_full_map, | |||
There was a problem hiding this comment.
@shinobu-x Looks indent is incorrect
| @@ -2357,8 +2379,9 @@ bool Objecter::is_pg_changed( | |||
|
|
|||
| bool Objecter::target_should_be_paused(op_target_t *t) | |||
| { | |||
| const pg_pool_t *pi = osdmap->get_pg_pool(t->base_oloc.pool); | |||
There was a problem hiding this comment.
@shinobu-x (NIT) Coding guide says about const names:
https://google.github.io/styleguide/cppguide.html#Variable_Names
Your thought please?
|
Hammer is EOL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/19141