New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: rbd ack cleanup #13791

Merged
merged 1 commit into from Mar 8, 2017

Conversation

Projects
None yet
3 participants
@runsisi
Contributor

runsisi commented Mar 4, 2017

since #12607 has killed the distinction between onack and onsafe, we can do a little bit cleanup now

Signed-off-by: runsisi runsisi@zte.com.cn

@runsisi

This comment has been minimized.

Contributor

runsisi commented Mar 4, 2017

@dillaman @trociny please take a look, thanks!

@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 6, 2017

@runsisi I would just squash the four commits down to a single commit since it doesn't compile after the first one.

runsisi
librbd: rados callback cleanup
Signed-off-by: runsisi <runsisi@zte.com.cn>
@runsisi

This comment has been minimized.

Contributor

runsisi commented Mar 7, 2017

@dillaman updated, thanks.

@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 7, 2017

retest this please

@dillaman

lgtm

@dillaman

This comment has been minimized.

Contributor

dillaman commented Mar 8, 2017

retest this please

@dillaman dillaman merged commit a581c6a into ceph:master Mar 8, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@runsisi runsisi deleted the runsisi:wip-rbd-ack-cleanup branch Mar 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment