OSD: drop parameter t from merge_log() #13923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregsfortytwo
previously approved these changes
Mar 11, 2017
|
Can you fix the build error? I assume it's just a test which also passes in the old param. |
xiexingguo
force-pushed
the
wip-clean-pglog-t
branch
from
dc2a11a
to
f222966
Compare
|
Sure. Repushed, let's wait and see. |
xiexingguo
force-pushed
the
wip-clean-pglog-t
branch
from
f222966
to
520e139
Compare
which is not necessary. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
wip-clean-pglog-t
branch
2 times, most recently
from
cb11f8d
to
65e0492
Compare
Which is definitely unnecessary. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
@athanatos Would you be able to review this PR? |
gregsfortytwo
approved these changes
Mar 17, 2017
|
Needs to get run through somebody's test suite but looks good. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is not necessary.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn