New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD: drop parameter t from merge_log() #13923

Merged
merged 2 commits into from Mar 20, 2017

Conversation

Projects
None yet
4 participants
@xiexingguo
Member

xiexingguo commented Mar 11, 2017

which is not necessary.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

Needs test update

@gregsfortytwo gregsfortytwo removed the needs-qa label Mar 11, 2017

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Mar 11, 2017

Can you fix the build error? I assume it's just a test which also passes in the old param.

@xiexingguo

This comment has been minimized.

Member

xiexingguo commented Mar 11, 2017

Sure. Repushed, let's wait and see.

xiexingguo added some commits Mar 11, 2017

OSD: drop parameter t from merge_log()
which is not necessary.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
OSD: drop parameter t from proc_replica_log()
Which is definitely unnecessary.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@shinobu-x

This comment has been minimized.

Contributor

shinobu-x commented Mar 11, 2017

@athanatos Would you be able to review this PR?

@tchaikov tchaikov self-requested a review Mar 11, 2017

@gregsfortytwo

Reviewed-by: Greg Farnum gfarnum@redhat.com

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Mar 17, 2017

Needs to get run through somebody's test suite but looks good. :)

@yuriw yuriw merged commit 1732698 into ceph:master Mar 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@xiexingguo xiexingguo deleted the xiexingguo:wip-clean-pglog-t branch Mar 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment