ASAP call oncommit callback function to make OSDOpReply firstly reply. #13989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@majianpeng your first commit has already been pulled by me. |
|
@liupan1111 . Ok, i'll remove this. |
majianpeng
force-pushed
the
op-commit-first-call
branch
from
df66659
to
bd02cde
Compare
|
Could you modify your pr title, and make it more meaningful? |
majianpeng
force-pushed
the
op-commit-first-call
branch
from
bd02cde
to
b8e70c4
Compare
majianpeng
changed the title
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
amitkumar50
suggested changes
Aug 17, 2017
| if (op->done()) { | ||
| assert(!op->on_commit && !op->on_applied); | ||
| in_progress_ops.erase(op->tid); | ||
| if (op->waiting_for_commit.empty()) { |
amitkumar50
reviewed
Aug 18, 2017
| assert(!op->on_commit && !op->on_applied); | ||
| in_progress_ops.erase(op->tid); | ||
| if (op->waiting_for_applied.empty()) { | ||
| assert(!op->on_applied); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make op_commit->complete ASAP be called because callback of op_commit send reply to client.