kraken: osd: pg log split does not rebuild index for parent or child #14048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pg_log_t::split_out_child() runs it builds the list, which means the old indexes are wrong (the point to bad memory), but index() will not rebuild them because ever since b858e86 we won't rebuild them if they are already built. Fix that by calling unindex() before the split. Further, the new child log also needs to be indexed. Fix that too. Fixes: http://tracker.ceph.com/issues/18975 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 643ae42)
Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit a6ead99)
|
@tchaikov This passed a rados suite at http://tracker.ceph.com/issues/19009#note-3 with one reproducible failure in OK to merge? |
tchaikov
approved these changes
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/19315