Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kraken: rbd: rbd --pool=x rename y z does not work #14149

Merged
merged 1 commit into from Apr 12, 2017
Merged

kraken: rbd: rbd --pool=x rename y z does not work #14149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion qa/workunits/rbd/copy.sh
View file
Open in desktop
Expand Up @@ -95,7 +95,8 @@ test_rename() {
rbd create -p rbd2 -s 1 foo
rbd rename rbd2/foo rbd2/bar
rbd -p rbd2 ls | grep bar
! rbd rename rbd2/bar foo
rbd rename rbd2/bar foo
rbd rename --pool rbd2 foo bar
! rbd rename rbd2/bar --dest-pool rbd foo
rbd rename --pool rbd2 bar --dest-pool rbd2 foo
rbd -p rbd2 ls | grep foo
Expand Down
2 changes: 1 addition & 1 deletion src/tools/rbd/action/Rename.cc
View file
Open in desktop
Expand Up @@ -42,9 +42,9 @@ int execute(const po::variables_map &vm) {
return r;
}

std::string dst_pool_name;
std::string dst_image_name;
std::string dst_snap_name;
std::string dst_pool_name = pool_name;
r = utils::get_pool_image_snapshot_names(
vm, at::ARGUMENT_MODIFIER_DEST, &arg_index, &dst_pool_name, &dst_image_name,
&dst_snap_name, utils::SNAPSHOT_PRESENCE_NONE, utils::SPEC_VALIDATION_FULL);
Expand Down