kraken: librbd: Incomplete declaration for ContextWQ in librbd/Journal.h #14153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use m_work_queue of type ContextWQ in handle_update function but we do not include common/WorkQueue.h that defines ContextWQ. This results in dereference of an incomplete type and causes build error in latest Fedora rawhide (future 26). Fixes: http://tracker.ceph.com/issues/18862 Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit 480f828)
smithfarm
changed the title
|
Jenkins retest this please (logs gone) |
|
@dillaman This passed an RBD suite at http://tracker.ceph.com/issues/19009#note-9 Please review/approve if you agree it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18892