kraken: objecter: epoch_barrier isn't respected in _op_submit() #14331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epoch barrier instructs us to avoid sending (i.e. pause) any OSD ops until we see a barrier epoch. The only thing epoch_barrier check in target_should_be_paused() does is keep already paused ops paused. We need to actually pause incoming OSD ops in _op_submit(). Fixes: http://tracker.ceph.com/issues/19396 Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit f8e8efc)
jdurgin
approved these changes
Apr 28, 2017
|
Jenkins re-test this please |
|
This passed a rados suite at http://tracker.ceph.com/issues/19009#note-51http://tracker.ceph.com/issues/19009#note-51 with two failures that I believe are unrelated. |
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/19496