kraken: core: ceph-disk: Add fix subcommand kraken back-port #14345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracked via http://tracker.ceph.com/issues/19544 |
|
@b-ranto Next time please set the milestone so the PR gets picked up for integration testing. |
smithfarm
suggested changes
Apr 22, 2017
|
@b-ranto Ping? Can you fix the cherry-picks please. |
|
This passed a ceph-disk suite at http://tracker.ceph.com/issues/19009#note-43 |
ghost
suggested changes
May 3, 2017
b-ranto
force-pushed
the
wip-ceph-disk-fix-kraken
branch
from
dad6372
to
d6601b7
Compare
|
Redid with the cherry-pick -x. |
smithfarm
approved these changes
May 3, 2017
ghost
approved these changes
May 3, 2017
|
jenkins test default |
|
Jenkins re-test this please |
1 similar comment
|
Jenkins re-test this please |
This subcommand will fix the SELinux labels and/or file permissions on ceph data (/var/lib/ceph). The command is also optimized to run the commands in parallel (per sub-dir in /var/lib/ceph) and do restorecon and chown at the same time to take advantage of the caching mechanisms. Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit 6d5d30f)
This will simulate the command* functions to not actually run anything thus excercising the python code directly. It also checks that the proper (sub-strings) are in the output. Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit 1ec53de)
It turns out I forgot several more directories that needs to be fixed by this script. We need to fix /var/log/ceph, /var/run/ceph and /etc/ceph as well. Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit ae13930)
This adds the ability to restore the labels of the underlying system data in addition to ceph data. Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit 8d81af4)
b-ranto
force-pushed
the
wip-ceph-disk-fix-kraken
branch
from
d6601b7
to
28e1fd0
Compare
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/19544
This back-ports quite cleanly (the only change is the doc format).