Make it possible for FileStore to be in a state which never do merge but keep it backward compatible #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich prevent it from merging, this could help: 1. We are trying to create the PG folder up to several levels with a standalone tool to prevent it from runtime splitting, we need a configuration which prevent it from merging even there is no file within the folder. 2. As runtime split / merge could bring latency issues, customer can use a negative merge threshold to prevent merging but only splitting. This change is backward compatbile. Signed-off-by: Guang Yang (yguang@yahoo-inc.com)
|
This should be re targeted at master. |
|
Thanks @athanatos , can you check this one - #1509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the configuration "filestore merge threshold" can be negative which prevent it from merging, this could help:
This change is backward compatbile.
Signed-off-by: Guang Yang (yguang@yahoo-inc.com)