kraken: tests: qa/tasks/workunit: Backport repo fixes from master #14487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as "workunits" reside in ceph/qa/workunits, it's more intuitive to respect suite-repo option when cloning workunits. Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 4cf28de)
…workunit repo if we run upgrade test, where, for example, "jewel" is not in ceph-ci.git repo, we should check ceph.git to clone the workunits. Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit edceabb)
Help avoid killing git.ceph.com. A depth 1 clone takes about 7 seconds, whereas a full one takes about 3:40 (much of it waiting for the server to create a huge compressed pack) Signed-off-by: Dan Mick <dan.mick@redhat.com> (cherry picked from commit c1309fb)
c1309fb failed to specify a branch when cloning using --depth=1, which by default clones the HEAD. and we can not "git checkout" a specific sha1 if it is not HEAD, after cloning using '--depth=1', so in this change, we dispatch "tag", "branch", "HEAD" using three Refspec classes. Signed-off-by: Kefu Chai <kchai@redhat.com> Signed-off-by: Dan Mick <dan.mick@redhat.com> (cherry picked from commit 9ca7ccf)
…unit otherwise the settings in "workunit" tasks are always overridden by the settings in template config. so we'd better follow the way of how "install" task updates itself with the "overrides" settings: it uses the "overrides" as the *defaults*. Fixes: http://tracker.ceph.com/issues/19429 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 4708015)
|
@smithfarm this PR is a superset of your #14394. as @zmc would like to have the other two commits in kraken too. |
|
@tchaikov OK, but do the other 2 commits need to be backported to all the other named branches, too? Or is it enough to have them in kraken? See http://tracker.ceph.com/issues/19429 |
|
@smithfarm no, as a feature, they are not needed. the minimum fix to accommodate the change on teuthology is #14394. but i am fine either way. |
tchaikov
approved these changes
Apr 13, 2017
|
Jenkins re-test this please |
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/19531