Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kraken: rbd: Add missing parameter feedback to 'rbd snap limit' #14537

Merged
merged 1 commit into from Apr 20, 2017

Conversation

smithfarm
Copy link
Contributor

Signed-off-by: Tang Jin <tang.jin@istuary.com>
(cherry picked from commit 8860028)
@smithfarm smithfarm self-assigned this Apr 13, 2017
@smithfarm smithfarm added this to the kraken milestone Apr 13, 2017
Copy link
Member

@joscollin joscollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed tracker information in the commit message.

@smithfarm
Copy link
Contributor Author

@joscollin Yes, that's intentional. Allow me to explain.

This is a backport - i.e. a cherry-pick. When backporting, we intentionally keep the original commit message as it is, adding information only to explain differences introduced by the backporting process (i.e. conflict resolution).

The advantage is that it is clear at first glance that this is a clean cherry-pick: nothing was changed. The tracker may be missing in the master commit, but if we "fix" that we introduce doubt concerning whether the cherry-pick is really clean.

@joscollin
Copy link
Member

@smithfarm Thanks for the explanation.

@smithfarm
Copy link
Contributor Author

@dillaman This passed an rbd suite at http://tracker.ceph.com/issues/19009#note-29

There are some failures in the upgrade/jewel-x and upgrade/client-upgrade suites, but the only unexplained one is http://tracker.ceph.com/issues/19637

OK to merge under those conditions?

@smithfarm smithfarm requested a review from dillaman April 20, 2017 08:27
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smithfarm smithfarm merged commit 2c1d5db into ceph:kraken Apr 20, 2017
@smithfarm smithfarm deleted the wip-18601-kraken branch April 20, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants