Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kraken: librbd: corrected resize RPC message backwards compatibility #14620

Merged
merged 1 commit into from Apr 20, 2017
Merged

kraken: librbd: corrected resize RPC message backwards compatibility #14620

merged 1 commit into from Apr 20, 2017

Conversation

smithfarm
Copy link
Contributor

@smithfarm
librbd: corrected resize RPC message backwards compatibility
1067764 
Commit d1f2c55 incorrectly changed the order of variables within
the payload. This resulted in breaking the resize RPC message
with older versions of Ceph.

Fixes: http://tracker.ceph.com/issues/19636
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 9db305a)
@smithfarm smithfarm self-assigned this Apr 18, 2017
@smithfarm smithfarm added this to the kraken milestone Apr 18, 2017
@smithfarm smithfarm changed the title kraken: upgrade:client-upgrade/{hammer,jewel}-client-x/rbd failing in kraken 11.2.1 integration testing kraken: librbd: corrected resize RPC message backwards compatibility Apr 18, 2017
@smithfarm smithfarm added rbd and removed core labels Apr 18, 2017
@smithfarm
Copy link
Contributor Author

@dillaman The failure persists even though this PR is included:

@smithfarm
Copy link
Contributor Author

But it's a different mode of failure than before:

2017-04-19T05:28:29.537 INFO:tasks.workunit.client.0.vpm021.stderr:+ python /home/ubuntu/cephtest/clone.client.0/qa/workunits/rbd/../../../src/test/librbd/test_notify.py master
2017-04-19T05:28:34.655 INFO:tasks.workunit.client.1.vpm063.stdout:starting slave
2017-04-19T05:28:34.655 INFO:tasks.workunit.client.1.vpm063.stdout:detected master
2017-04-19T05:28:34.655 INFO:tasks.workunit.client.1.vpm063.stdout:rename
2017-04-19T05:28:34.655 INFO:tasks.workunit.client.1.vpm063.stdout:flatten
2017-04-19T05:28:34.656 INFO:tasks.workunit.client.1.vpm063.stdout:resize
2017-04-19T05:28:34.656 INFO:tasks.workunit.client.1.vpm063.stdout:create_snap
2017-04-19T05:28:34.656 INFO:tasks.workunit.client.1.vpm063.stdout:protect_snap
2017-04-19T05:28:34.656 INFO:tasks.workunit.client.1.vpm063.stdout:unprotect_snap
2017-04-19T05:28:34.656 INFO:tasks.workunit.client.1.vpm063.stdout:rename_snap
2017-04-19T05:28:34.656 INFO:tasks.workunit.client.1.vpm063.stdout:remove_snap
2017-04-19T05:28:34.656 INFO:tasks.workunit.client.1.vpm063.stdout:rebuild object map
2017-04-19T05:28:34.656 INFO:tasks.workunit.client.1.vpm063.stderr:Traceback (most recent call last):
2017-04-19T05:28:34.656 INFO:tasks.workunit.client.1.vpm063.stderr:  File "/home/ubuntu/cephtest/clone.client.1/qa/workunits/rbd/../../../src/test/librbd/test_notify.py", line 170, in <module>
2017-04-19T05:28:34.656 INFO:tasks.workunit.client.1.vpm063.stderr:    main()
2017-04-19T05:28:34.657 INFO:tasks.workunit.client.1.vpm063.stderr:  File "/home/ubuntu/cephtest/clone.client.1/qa/workunits/rbd/../../../src/test/librbd/test_notify.py", line 166, in main
2017-04-19T05:28:34.657 INFO:tasks.workunit.client.1.vpm063.stderr:    slave(ioctx)
2017-04-19T05:28:34.657 INFO:tasks.workunit.client.1.vpm063.stderr:  File "/home/ubuntu/cephtest/clone.client.1/qa/workunits/rbd/../../../src/test/librbd/test_notify.py", line 141, in slave
2017-04-19T05:28:34.658 INFO:tasks.workunit.client.1.vpm063.stderr:    False)
2017-04-19T05:28:34.658 INFO:tasks.workunit.client.1.vpm063.stderr:  File "rbd.pyx", line 1474, in rbd.Image.update_features (/build/ceph-11.2.0-359-gf2fdbbe/obj-x86_64-linux-gnu/src/pybind/rbd/pyrex/rbd.c:13173)
2017-04-19T05:28:34.658 INFO:tasks.workunit.client.1.vpm063.stderr:rbd.InvalidArgument: error updating features for image test_notify_clone2

@smithfarm
Copy link
Contributor Author

@dillaman I populated a new version of wip-kraken-backports including this PR, and re-ran the upgrade/client-upgrade suite. The two jobs that were failing before were "hammer-client-x" and "jewel-client-x". Of these, the former is fixed but the latter is showing the new failure mentioned above (I ran both jobs 5 times each to be certain).

See http://tracker.ceph.com/issues/19009#note-32 for the pulpito URLs.

Thanks for helping with this.

@dillaman
Copy link

@smithfarm Yeah -- different issue where the upgrade test overrides the default features for jewel which results in this failure. Tracker via http://tracker.ceph.com/issues/19692

dillaman
dillaman approved these changes Apr 19, 2017
View reviewed changes
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smithfarm smithfarm merged commit e68d3e1 into ceph:kraken Apr 20, 2017
@smithfarm smithfarm deleted the wip-19659-kraken branch April 20, 2017 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillaman dillaman dillaman approved these changes

Assignees

@smithfarm smithfarm

Labels
bug-fix rbd
Projects
None yet
Milestone
kraken
2 participants
@smithfarm @dillaman