Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kraken: osd: pglog: with config, don't assert in the presence of stale diverg… #14646

Merged
merged 1 commit into from Jul 5, 2017
Merged

kraken: osd: pglog: with config, don't assert in the presence of stale diverg… #14646

merged 1 commit into from Jul 5, 2017

Conversation

gregsfortytwo
Copy link
Member

@gregsfortytwo gregsfortytwo commented Apr 20, 2017 •
edited by smithfarm

…ent_priors

This forward-ports the few pieces of divergent_priors handling code that need to deal with stale values on-disk for upgraded systems.

http://tracker.ceph.com/issues/19702

@gregsfortytwo gregsfortytwo added this to the kraken milestone Apr 20, 2017
@gregsfortytwo
Copy link
Member Author

Backport ticket: http://tracker.ceph.com/issues/19702

@smithfarm
Copy link
Contributor

This passed a rados suite at http://tracker.ceph.com/issues/19009#note-37 (3 tests failed initially, but passed the second time around)

@smithfarm
Copy link
Contributor

Jenkins re-test this please

@smithfarm
Copy link
Contributor

@gregsfortytwo The make check failure has hopefully been fixed by #16069 - could you please rebase to pick it up?

@smithfarm smithfarm changed the title osd: pglog: with config, don't assert in the presence of stale diverg… [DNM] osd: pglog: with config, don't assert in the presence of stale diverg… Jul 3, 2017
@smithfarm
Copy link
Contributor

Jenkins re-test this please

@smithfarm
Copy link
Contributor

Nevermind, rebase not necessary (Jenkins merges into latest base branch before starting the test).

Jenkins re-test this please

@smithfarm smithfarm changed the title [DNM] osd: pglog: with config, don't assert in the presence of stale diverg… kraken: osd: pglog: with config, don't assert in the presence of stale diverg… Jul 3, 2017
@smithfarm smithfarm requested a review from jdurgin July 4, 2017 08:29
@smithfarm
Copy link
Contributor

@gregsfortytwo @jdurgin This passed a rados suite at http://tracker.ceph.com/issues/19009#note-37 (3 tests failed initially, but passed the second time around). Please review and/or merge if you think this constitutes sufficient testing.

@gregsfortytwo
Copy link
Member Author

Looks good to me!

@smithfarm
Copy link
Contributor

@jdurgin This passed another rados suite at http://tracker.ceph.com/issues/19009#note-51http://tracker.ceph.com/issues/19009#note-51 with two failures that I believe are unrelated. Please review/approve the PR if you agree it can be merged.

@smithfarm smithfarm merged commit 11ed483 into ceph:kraken Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdurgin jdurgin jdurgin approved these changes

Assignees
No one assigned
Labels
bug-fix core
Projects
None yet
Milestone
kraken
4 participants
@gregsfortytwo @smithfarm @jdurgin @liewegas