rbd-mirror: image deletions should be handled by assigned instance #14832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trociny
reviewed
Apr 27, 2017
| @@ -175,9 +175,6 @@ class BootstrapRequest : public BaseRequest { | |||
|
|
|||
| bufferlist m_out_bl; | |||
|
|
|||
| void get_local_image_id(); | |||
| void handle_get_local_image_id(int r); | |||
There was a problem hiding this comment.
need to update the state diagram
added 6 commits
April 27, 2017 15:54
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This state machine will be invoked before the bootstrap state machine and will be responsible for detecting if the local image is already primary or if it needs to be deleted. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
force-pushed
the
wip-rbd-mirror-deletion
branch
from
52052a5
to
cbe469f
Compare
trociny
reviewed
Apr 27, 2017
| @@ -335,7 +336,8 @@ void ImageReplayer<I>::add_remote_image(const std::string &mirror_uuid, | |||
|
|
|||
| template <typename I> | |||
| void ImageReplayer<I>::remove_remote_image(const std::string &mirror_uuid, | |||
| const std::string &image_id) { | |||
| const std::string &image_id, | |||
| bool schedule_delete) { | |||
There was a problem hiding this comment.
nit: you might want to use spaces vs tabs here
| @@ -109,7 +109,8 @@ class ImageReplayer { | |||
| const std::string &remote_image_id, | |||
| librados::IoCtx &remote_io_ctx); | |||
| void remove_remote_image(const std::string &remote_mirror_uuid, | |||
| const std::string &remote_image_id); | |||
| const std::string &remote_image_id, | |||
| bool schedule_delete); | |||
| image_replayer->remove_remote_image(peer_mirror_uuid, peer_image_id); | ||
| if (!peer_mirror_uuid.empty()) { | ||
| image_replayer->remove_remote_image(peer_mirror_uuid, peer_image_id, | ||
| schedule_delete); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.