New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/fsx: Remove the dead code associated with aio backend #14905

Merged
merged 1 commit into from May 10, 2017

Conversation

Projects
None yet
4 participants
@johnzzpcrystal
Contributor

johnzzpcrystal commented May 2, 2017

No description provided.

@@ -2504,8 +2504,10 @@ __aio_rw(int rw, int fd, char *buf, unsigned len, unsigned offset)
} while (ret == -EINTR);
if (ret != 1) {
if (ret == 0)
if (ret == 0) {

This comment has been minimized.

@tchaikov

tchaikov May 2, 2017

Contributor

please note that this is dead code in ceph. it's never executed in the ceph variant of fsx. instead, we use {p,librbd_}{write,read} for kbd/rbd-nbd and rbd modes. i wonder if we can just remove the aio backend for the read/write tests.

This comment has been minimized.

@dillaman

dillaman May 2, 2017

Contributor

@tchaikov I'm fine w/ removing the dead code

This comment has been minimized.

@johnzzpcrystal

johnzzpcrystal May 2, 2017

Contributor

OK, I'll close it later

This comment has been minimized.

@johnzzpcrystal

johnzzpcrystal May 2, 2017

Contributor

Maybe I could upload a new patch to remove these dead code ?

This comment has been minimized.

@dillaman

dillaman May 3, 2017

Contributor

@johnzzpcrystal Sounds good to me -- just force push your changes to the existing branch.

@tchaikov tchaikov changed the title from test: fix two error handling problems to test/fsx: fix two error handling problems May 2, 2017

@tchaikov tchaikov requested a review from dillaman May 2, 2017

@johnzzpcrystal johnzzpcrystal changed the title from test/fsx: fix two error handling problems to test/fsx: Remove the dead code associated with aio backend May 3, 2017

@dillaman

This comment has been minimized.

Contributor

dillaman commented May 3, 2017

@johnzzpcrystal Please squash your three commits down into a single commit (since the first two will essentially be dropped by the third).

test/fsx: Remove the dead code associated with aio backend
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>

@tchaikov tchaikov added the needs-qa label May 4, 2017

@johnzzpcrystal

This comment has been minimized.

Contributor

johnzzpcrystal commented May 9, 2017

@dillaman, Could this be merged ?

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 9, 2017

@johnzzpcrystal i am running this PR through the rados test suite. but we might need to run it through the rbd suite also.

@johnzzpcrystal

This comment has been minimized.

Contributor

johnzzpcrystal commented May 9, 2017

@tchaikov, Thanks a lot !

@dillaman

This comment has been minimized.

Contributor

dillaman commented May 9, 2017

@tchaikov Yes, it needs to go through an rbd suite run

@liewegas liewegas merged commit bd71ca3 into ceph:master May 10, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@liewegas

This comment has been minimized.

Member

liewegas commented May 10, 2017

oops! didn't see the rbd comment. hopefully this one is okay.

@johnzzpcrystal johnzzpcrystal deleted the johnzzpcrystal:aio branch May 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment