test/fsx: Remove the dead code associated with aio backend #14905
Conversation
src/test/librbd/fsx.cc
Outdated
| @@ -2504,8 +2504,10 @@ __aio_rw(int rw, int fd, char *buf, unsigned len, unsigned offset) | |||
| } while (ret == -EINTR); | |||
|
|
|||
| if (ret != 1) { | |||
| if (ret == 0) | |||
| if (ret == 0) { | |||
There was a problem hiding this comment.
please note that this is dead code in ceph. it's never executed in the ceph variant of fsx. instead, we use {p,librbd_}{write,read} for kbd/rbd-nbd and rbd modes. i wonder if we can just remove the aio backend for the read/write tests.
There was a problem hiding this comment.
@tchaikov I'm fine w/ removing the dead code
There was a problem hiding this comment.
OK, I'll close it later
There was a problem hiding this comment.
Maybe I could upload a new patch to remove these dead code ?
There was a problem hiding this comment.
@johnzzpcrystal Sounds good to me -- just force push your changes to the existing branch.
tchaikov
changed the title
johnzzpcrystal
changed the title
|
@johnzzpcrystal Please squash your three commits down into a single commit (since the first two will essentially be dropped by the third). |
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>
|
@dillaman, Could this be merged ? |
|
@johnzzpcrystal i am running this PR through the rados test suite. but we might need to run it through the rbd suite also. |
|
@tchaikov, Thanks a lot ! |
|
@tchaikov Yes, it needs to go through an rbd suite run |
|
oops! didn't see the rbd comment. hopefully this one is okay. |
No description provided.