Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kraken: librbd: default initialize snapshot namespace for legacy clients #14934

Merged
merged 1 commit into from Jul 5, 2017

Conversation

dillaman
Copy link

@dillaman dillaman commented May 3, 2017

Creating a snapshot on >=Kraken OSDs using <=Jewel clients can result
in an improperly initialized snapshot namespace. As a result, attempting
to remove the snapshot using a >=Kraken client will result in an -EINVAL
error.

Fixes: http://tracker.ceph.com/issues/19413
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 03b0b03)

Conflicts:
	src/cls/rbd/cls_rbd.h: trivial resolution
@dillaman dillaman added this to the kraken milestone May 3, 2017
Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smithfarm
Copy link
Contributor

Jenkins re-test this please

1 similar comment
@smithfarm
Copy link
Contributor

Jenkins re-test this please

@smithfarm
Copy link
Contributor

This PR passed an rbd run at http://tracker.ceph.com/issues/19009#note-56 (there were some failures that required a fix - applied via #16113).

@smithfarm smithfarm merged commit e705528 into ceph:kraken Jul 5, 2017
@smithfarm smithfarm changed the title kraken: cls_rbd: default initialize snapshot namespace for legacy clients kraken: rbd: default initialize snapshot namespace for legacy clients Aug 2, 2017
@smithfarm smithfarm changed the title kraken: rbd: default initialize snapshot namespace for legacy clients kraken: librbd: default initialize snapshot namespace for legacy clients Aug 2, 2017
@dillaman dillaman deleted the wip-19833-kraken branch September 7, 2017 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants