Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kraken: rbd-mirror: failover and failback of unmodified image results in split-brain #14974

Merged
merged 2 commits into from Jul 5, 2017
Merged

kraken: rbd-mirror: failover and failback of unmodified image results in split-brain #14974

merged 2 commits into from Jul 5, 2017

Conversation

dillaman
Copy link

@dillaman dillaman commented May 5, 2017

@dillaman dillaman added this to the kraken milestone May 5, 2017
@trociny
Copy link
Contributor

trociny commented May 5, 2017

@ceph-jenkins retest this please

trociny
trociny approved these changes May 5, 2017
View reviewed changes
Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smithfarm
Copy link
Contributor

Jenkins re-test this please (logs are gone)

@smithfarm
Copy link
Contributor

@dillaman Please rebase to get rid of the obsolete failed default Jenkins test

Jason Dillaman added 2 commits June 26, 2017 21:53
rbd-mirror: prevent infinite loop when computing replay status
1d71475 
If the image had a non-primary predecessor epoch whose tag tid
duplicates an epoch within its own journal, an infinite loop
would result.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 3f179bf)
librbd: add no-op event when promoting an image
9efeb6b 
The rbd-mirror process needs an event in the journal
to properly detect the transition between primary and
non-primary state between peers.

Fixes: http://tracker.ceph.com/issues/19858
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 4031555)

Conflicts:
	src/librbd/journal/DemoteRequest.cc: logic exists in Journal.cc
@dillaman
Copy link
Author

@smithfarm sorry -- repushed.

BTW -- what at the odds of a 11.2.1 being released before Kraken is killed off by Luminous 12.2.0?

@smithfarm
Copy link
Contributor

@dillaman I'd say 50:50. I'm focusing on 10.2.8 now, and will turn to 11.2.1 once that's in QE.

@smithfarm
Copy link
Contributor

Jenkins re-test this please (kraken "make check" is showing a high incidence of the "Unix Domain socket path too long" failure)

@smithfarm
Copy link
Contributor

@dillaman The make check failure has hopefully been fixed by #16069 - could you please rebase to pick it up?

@smithfarm smithfarm changed the title kraken: rbd-mirror: failover and failback of unmodified image results in split-brain [DNM] kraken: rbd-mirror: failover and failback of unmodified image results in split-brain Jul 3, 2017
@smithfarm smithfarm changed the title [DNM] kraken: rbd-mirror: failover and failback of unmodified image results in split-brain kraken: rbd-mirror: failover and failback of unmodified image results in split-brain Jul 3, 2017
@smithfarm
Copy link
Contributor

Nevermind, rebase not necessary (Jenkins merges into latest base branch before starting the test).

Jenkins re-test this please

@smithfarm
Copy link
Contributor

This PR passed an rbd run at http://tracker.ceph.com/issues/19009#note-56 (there were some failures that required a fix - applied via #16113).

@smithfarm smithfarm merged commit cc5241e into ceph:kraken Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trociny trociny trociny approved these changes

Assignees
No one assigned
Labels
bug-fix rbd
Projects
None yet
Milestone
kraken
3 participants
@dillaman @trociny @smithfarm