kraken: osd: osd/PrimaryLogPG: do not call on_shutdown() if (pg.deleting) #15066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a callback is called, it could be facing a PG already shut down by OSD. but if that callback wants to shut that PG down. it should check the PG's status first. Fixes: http://tracker.ceph.com/issues/19902 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit f3c44a0)
smithfarm
changed the title
|
Jenkins re-test this please |
|
Jenkins re-test this please (kraken "make check" is showing a high incidence of the "Unix Domain socket path too long" failure) |
|
@asheplyakov The make check failure has hopefully been fixed by #16069 - could you please rebase to pick it up? |
smithfarm
changed the title
smithfarm
changed the title
|
Nevermind, rebase not necessary (Jenkins merges into latest base branch before starting the test). Jenkins re-test this please |
|
@jdurgin This passed a rados suite at http://tracker.ceph.com/issues/19009#note-51http://tracker.ceph.com/issues/19009#note-51 with two failures that I believe are unrelated. Please review/approve the PR if you agree it can be merged. |
jdurgin
approved these changes
Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/19916