build: remove boost_python from the standard link list. #15344
Conversation
- Cmake and Boost return a list of libraries to liink in Boost_LIBRARIES. Under FreeBSD it also contains libboost-python. Which is not what is expect. So we remove this entry from the list. Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
| @@ -597,6 +597,10 @@ set(Boost_USE_MULTITHREADED ON) | |||
| find_package(Boost 1.61 COMPONENTS ${BOOST_COMPONENTS} REQUIRED) | |||
| include_directories(SYSTEM ${Boost_INCLUDE_DIRS}) | |||
| include_directories(SYSTEM ${PROJECT_BINARY_DIR}/include) | |||
| if(FREEBSD) | |||
| list(REMOVE_ITEM Boost_LIBRARIES "/usr/local/lib/libboost_python.so") | |||
There was a problem hiding this comment.
instead of making a surgery on Boost_LIBRARIES, i'd recommend only link the necessary boost libs. i will prepare another PR later on.
There was a problem hiding this comment.
@tchaikov
Make sense. Prevents dependany on what is embeded in the default stuff that comes with the packages. But note that I'm using the SYSTEM stuff, so I have no idea how that impacts your solution.
|
@wjwithagen if you are happy with #15346, we can close this PR. as it supersedes this one. |
|
@tchaikov And then still do I need to add |
|
@wjwithagen i agree with you. see #15225, i believe it would address your issue. my changes are moved there. ahh, i was wrong. see #15347. i reopened it. sorry for the confusion. |
|
since #15347 is merged, i am closing this one. |
Boost_LIBRARIES. Under FreeBSD it also contains libboost-python.
Which is not what is expect.
So we remove this entry from the list.
Signed-off-by: Willem Jan Withagen wjw@digiware.nl