New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jewel: rgw: multisite: operating bucket's acl&cors is not restricted on slave zone #15453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
changed the title
jewel: [multisite] operating bucket's acl&cors is not restricted on slave zone
jewel: rgw: multisite: operating bucket's acl&cors is not restricted on slave zone
Jun 3, 2017
Needs #15260 once it's merged. |
smithfarm
changed the title
jewel: rgw: multisite: operating bucket's acl&cors is not restricted on slave zone
[DNM] jewel: rgw: multisite: operating bucket's acl&cors is not restricted on slave zone
Jun 19, 2017
Fixes: http://tracker.ceph.com/issues/16888 Signed-off-by: Guo Zhandong <guozhandong@cmss.chinamobile.com> (cherry picked from commit 5f89d37)
PutACL rejects request that include both a canned_acl and a request body. when forwarding requests with canned_acls, we were also including the generated policy in the body Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 1c863a7)
pr#14082 is incomplete, cors should be redirect to master Fixes: http://tracker.ceph.com/issues/16888 Signed-off-by: Shasha Lu <lu.shasha@eisoo.com> (cherry picked from commit 7dd0995) Conflicts: src/rgw/rgw_op.cc (jewel does not have 5fff637) src/test/rgw/rgw_multi/tests.py (jewel does not have this file)
smithfarm
force-pushed
the
wip-19768-jewel
branch
from
June 20, 2017 21:54
035e321
to
a36211c
Compare
smithfarm
changed the title
[DNM] jewel: rgw: multisite: operating bucket's acl&cors is not restricted on slave zone
jewel: rgw: multisite: operating bucket's acl&cors is not restricted on slave zone
Jun 20, 2017
cbodley
approved these changes
Jun 21, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Jenkins re-test this please (Unexpected die of job) |
This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-18 and @cbodley has already approved it, so I'll merge unless there are objections. |
cbodley
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/19768