New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: multisite: memory leak on failed lease in RGWDataSyncShardCR #15457

Merged
merged 3 commits into from Aug 26, 2017

Conversation

Projects
None yet
4 participants

@smithfarm smithfarm self-assigned this Jun 3, 2017

@smithfarm smithfarm added this to the jewel milestone Jun 3, 2017

@smithfarm smithfarm added bug fix core rgw and removed core labels Jun 3, 2017

@smithfarm smithfarm changed the title from jewel: multisite: memory leak on failed lease in RGWDataSyncShardCR to jewel: rgw: multisite: memory leak on failed lease in RGWDataSyncShardCR Jun 3, 2017

@idealguo

This comment has been minimized.

Show comment
Hide comment
@idealguo

idealguo Jun 16, 2017

@smithfarm , Can we put this fix into 10.2.8? it fixes memory leak, seems important.

idealguo commented Jun 16, 2017

@smithfarm , Can we put this fix into 10.2.8? it fixes memory leak, seems important.

weiqiaomiao and others added some commits Jun 27, 2016

rgw: should delete in_stream_req if conn->get_obj(...) return not zer…
…o value

Signed-off-by: weiqiaomiao <wei.qiaomiao@zte.com.cn>
(cherry picked from commit 494fbe9)
rgw: dont spawn error_repo until lease is acquired
if RGWDataSyncShardCR fails to acquire its lease, it doesn't call
error_repo->finish() to stop the coroutine. wait until the lease
succeeds before spawning the error_repo

Fixes: http://tracker.ceph.com/issues/19446

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 1524a5e)

Conflicts:
        src/rgw/rgw_data_sync.cc (different argument list of RGWOmapAppend()
            function in jewel, compared to master)
rgw: RGWPeriodPusher spawns http thread before cr thread
Fixes: http://tracker.ceph.com/issues/19834

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 21a943d)

dongbula pushed a commit to dongbula/ceph that referenced this pull request Jul 22, 2017

Merge pull request #15457 from smithfarm/wip-20018-jewel
jewel: rgw: multisite: memory leak on failed lease in RGWDataSyncShardCR

Signed-off-by: weiqiaomiao <wei.qiaomiao@zte.com.cn>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 25, 2017

Contributor

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-18 and @cbodley has already approved it, so I'll merge unless there are objections.

Contributor

smithfarm commented Aug 25, 2017

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-18 and @cbodley has already approved it, so I'll merge unless there are objections.

@smithfarm smithfarm merged commit ccf9d71 into ceph:jewel Aug 26, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-20018-jewel branch Aug 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment