jewel: rgw: multisite: memory leak on failed lease in RGWDataSyncShardCR #15457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
changed the title
|
@smithfarm , Can we put this fix into 10.2.8? it fixes memory leak, seems important. |
if RGWDataSyncShardCR fails to acquire its lease, it doesn't call error_repo->finish() to stop the coroutine. wait until the lease succeeds before spawning the error_repo Fixes: http://tracker.ceph.com/issues/19446 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 1524a5e) Conflicts: src/rgw/rgw_data_sync.cc (different argument list of RGWOmapAppend() function in jewel, compared to master)
…o value Signed-off-by: weiqiaomiao <wei.qiaomiao@zte.com.cn> (cherry picked from commit 494fbe9)
Fixes: http://tracker.ceph.com/issues/19834 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 21a943d)
smithfarm
force-pushed
the
wip-20018-jewel
branch
from
32a77d9
to
8cf3f18
Compare
cbodley
approved these changes
Jun 16, 2017
|
This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-18 and @cbodley has already approved it, so I'll merge unless there are objections. |
cbodley
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/20018
http://tracker.ceph.com/issues/20020