client: avoid returning negative space available #15481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
requested changes
Jun 5, 2017
src/client/Client.cc
Outdated
| const fsblkcnt_t free = total - used; | ||
| // It is possible for a quota to be exceeded: arithmetic here must | ||
| // handle case where used > total. | ||
| const fsblkcnt_t free = MAX(0, total - used); |
There was a problem hiding this comment.
if fsblkcnt_t is an unsigned type, we might need to cast it to a signed type first.
There was a problem hiding this comment.
Good point, amended to do it another way
...when a quota is set and the used bytes exceed the quota. Fixes: http://tracker.ceph.com/issues/20178 Signed-off-by: John Spray <john.spray@redhat.com>
batrick
approved these changes
Jun 5, 2017
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...when a quota is set and the used bytes exceed
the quota.
Fixes: http://tracker.ceph.com/issues/20178
Signed-off-by: John Spray john.spray@redhat.com