mon/LogMonitor: 'log last' command #15497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
liewegas
commented
Jun 5, 2017
liewegas
commented
- also clean up LogSummary class
Signed-off-by: Sage Weil <sage@redhat.com>
A linear search here is dumb. Use an unordered_set. Signed-off-by: Sage Weil <sage@redhat.com>
Default to 20 lines of log if not specified. Signed-off-by: Sage Weil <sage@redhat.com>
|
The use of LogSummary could stand to be rewritten, but this is simple and works (for up to 1024 recent entries). |
tchaikov
reviewed
Jun 6, 2017
| @@ -97,24 +105,22 @@ WRITE_CLASS_ENCODER_FEATURES(LogEntry) | |||
| struct LogSummary { | |||
| version_t version; | |||
| list<LogEntry> tail; | |||
| ceph::unordered_set<LogEntryKey> keys; | |||
There was a problem hiding this comment.
if we want to be spacial efficient, probably we can just keep the hashed LogEntryKey around?
| @@ -197,6 +197,9 @@ COMMAND_WITH_FLAG("scrub", "scrub the monitor stores", \ | |||
| COMMAND("fsid", "show cluster FSID/UUID", "mon", "r", "cli,rest") | |||
| COMMAND("log name=logtext,type=CephString,n=N", \ | |||
| "log supplied text to the monitor log", "mon", "rw", "cli,rest") | |||
| COMMAND("log last name=num,type=CephInt,range=1,req=false", \ | |||
There was a problem hiding this comment.
can we have a test in, for example, src/test/mon/misc.sh ?
This avoids recalculating. We eliminate the default ctor at the same time and make the type totally opaque (so that its fields cannot be modified except by the ctor and decode). Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
tchaikov
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.