doc: update sample explaining "%" operator in test suites #15511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
changed the title
smithfarm
reviewed
Jun 6, 2017
doc/dev/index.rst
Outdated
| files. For instance, all tests in the `rados/basic suite | ||
| <https://github.com/ceph/ceph/tree/master/qa/suites/rados/basic>`_ | ||
| run with different messenger types: ``simple``, ``async`` and | ||
| ``random``, because they are combined (via special file ``%``) with the |
There was a problem hiding this comment.
s/via special/via the special/
smithfarm
reviewed
Jun 6, 2017
| @@ -1132,11 +1132,12 @@ Reducing the number of tests | |||
| ---------------------------- | |||
|
|
|||
| The ``rados`` suite generates thousands of tests out of a few hundred | |||
| files. For instance, all tests in the `rados/thrash suite | |||
There was a problem hiding this comment.
This happens because teuthology constructs test matrices from subdirectories wherever it encounters a file named %.
There was a problem hiding this comment.
Suggest to insert new sentence after "files." and before "For instance,"
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-doc-cartesian-product
branch
from
5117dd2
to
b85bf0e
Compare
|
@smithfarm fixed and repushed. |
smithfarm
approved these changes
Jun 6, 2017
ghost
approved these changes
Jun 6, 2017
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kefu Chai kchai@redhat.com