New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update sample explaining "%" operator in test suites #15511

Merged
merged 1 commit into from Jun 6, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Jun 6, 2017

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov requested a review from smithfarm Jun 6, 2017

@tchaikov tchaikov changed the title from doc: update sample explaning "%" operator in tes suites to doc: update sample explaning "%" operator in test suites Jun 6, 2017

@smithfarm smithfarm requested a review from Jun 6, 2017

files. For instance, all tests in the `rados/basic suite
<https://github.com/ceph/ceph/tree/master/qa/suites/rados/basic>`_
run with different messenger types: ``simple``, ``async`` and
``random``, because they are combined (via special file ``%``) with the

This comment has been minimized.

@smithfarm

smithfarm Jun 6, 2017

Contributor

s/via special/via the special/

@@ -1132,11 +1132,12 @@ Reducing the number of tests
----------------------------
The ``rados`` suite generates thousands of tests out of a few hundred
files. For instance, all tests in the `rados/thrash suite

This comment has been minimized.

@smithfarm

smithfarm Jun 6, 2017

Contributor

This happens because teuthology constructs test matrices from subdirectories wherever it encounters a file named %.

This comment has been minimized.

@smithfarm

smithfarm Jun 6, 2017

Contributor

Suggest to insert new sentence after "files." and before "For instance,"

doc: update sample explaning "%" operator in tes suites
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 6, 2017

@smithfarm fixed and repushed.

@ghost

ghost approved these changes Jun 6, 2017

@tchaikov tchaikov merged commit e38ca14 into ceph:master Jun 6, 2017

2 of 3 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@tchaikov tchaikov deleted the tchaikov:wip-doc-cartesian-product branch Jun 6, 2017

@smithfarm smithfarm changed the title from doc: update sample explaning "%" operator in test suites to doc: update sample explaining "%" operator in test suites Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment