Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kraken: osd: Implement asynchronous scrub sleep #15526

Merged
merged 2 commits into from Aug 1, 2017
Merged

kraken: osd: Implement asynchronous scrub sleep #15526

merged 2 commits into from Aug 1, 2017

Conversation

badone
Copy link
Contributor

@badone badone commented Jun 6, 2017 •
edited by smithfarm

@badone badone added this to the kraken milestone Jun 6, 2017
@badone
Copy link
Contributor Author

badone commented Jun 7, 2017

Jenkins, Retest this please

@smithfarm smithfarm changed the title Kraken: osd: Implement asynchronous scrub sleep kraken: osd: Implement asynchronous scrub sleep Jun 7, 2017
@badone
Copy link
Contributor Author

badone commented Jun 7, 2017

Test this please

@badone
Copy link
Contributor Author

badone commented Jun 8, 2017

Jenkins, Retest this please

@badone
Copy link
Contributor Author

badone commented Jun 18, 2017

Jenkins retest this please

@badone
Copy link
Contributor Author

badone commented Jun 19, 2017

Sigh... Jenkins retest this please.

@smithfarm
Copy link
Contributor

@badone Likely conflict with #14597

@smithfarm smithfarm changed the title kraken: osd: Implement asynchronous scrub sleep [DNM] kraken: osd: Implement asynchronous scrub sleep Jul 4, 2017
@badone
Copy link
Contributor Author

badone commented Jul 4, 2017

@smithfarm Still showing all green and able to merge?

@smithfarm
Copy link
Contributor

@badone It conflicts with #14597 - in other words, when that PR merges, this one will no longer be green.

There's nothing wrong with this PR, per se - it's just that when I populate the integration branch one or the other of the conflicting PRs has to be excluded.

@badone
Copy link
Contributor Author

badone commented Jul 4, 2017

@smithfarm I guess what I'm asking is what do you want me to do right now?

@smithfarm
Copy link
Contributor

@badone Regarding this PR, nothing, but if you'd care to help me figure out which missing backport might be causing the bluestore leaks in http://pulpito.ceph.com/smithfarm-2017-07-04_09:48:04-rgw-wip-kraken-backports-distro-basic-smithi/ (all the "saw valgrind issues" failures) that would be fantastic!

@smithfarm
Copy link
Contributor

The sooner that leak can be fixed, the sooner we can merge #14597 and the sooner you could retool this PR.

@smithfarm
Copy link
Contributor

@badone Apparently those leaks might be fixed by yet-to-be-merged ceph/ceph-ci@42db0c7

@smithfarm
Copy link
Contributor

@badone Nope, I was wrong again ;-) The commit has been merged and here is the backport: #16109

@smithfarm smithfarm mentioned this pull request Jul 5, 2017
Merged
@smithfarm smithfarm changed the title [DNM] kraken: osd: Implement asynchronous scrub sleep kraken: osd: Implement asynchronous scrub sleep Jul 6, 2017
@smithfarm smithfarm changed the title kraken: osd: Implement asynchronous scrub sleep [DNM] kraken: osd: Implement asynchronous scrub sleep Jul 7, 2017
@smithfarm
Copy link
Contributor

Marking DNM so I can bisect this failure: http://tracker.ceph.com/issues/19009#note-62

@smithfarm
Copy link
Contributor

Will try to get #14597 in, first. If that goes well, @badone can rebase this PR and I'll run it through a rados suite all by itself.

@smithfarm smithfarm changed the title [DNM] kraken: osd: Implement asynchronous scrub sleep kraken: osd: Implement asynchronous scrub sleep Jul 21, 2017
@smithfarm
Copy link
Contributor

#14597 has been tested, so this one is up next.

@smithfarm
Copy link
Contributor

#14597 was just merged; @badone please rebase

@badone
osd: Implement asynchronous scrub sleep
460a820 
Rather than blocking the main op queue just do an async sleep.

Fixes: http://tracker.ceph.com/issues/19497

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
(cherry picked from commit 7af3e86)
@badone badone force-pushed the wip-async-sleep-timer-fix-kraken branch from 0c57526 to 89131e3 Compare July 25, 2017 06:11
@badone badone force-pushed the wip-async-sleep-timer-fix-kraken branch from 89131e3 to d6f67d4 Compare July 25, 2017 06:23
@badone
osd: Move scrub sleep timer to osdservice
719ed01 
PR 14886 erroneously creates a scrub sleep timer for every pg resulting
in a proliferation of threads. Move the timer to the osd service so
there can be only one.

Fixes: http://tracker.ceph.com/issues/19986

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
(cherry picked from commit f110a82)
@badone badone force-pushed the wip-async-sleep-timer-fix-kraken branch from d6f67d4 to 719ed01 Compare July 26, 2017 04:25
@badone
Copy link
Contributor Author

badone commented Jul 26, 2017

@smithfarm Current kraken is very hard to build using gcc7 atm (check my upcoming email to ceph-devel) so I tried to "wing it" last night and of course failed :( I've fixed the commit, built and tested today so we should be good to go I hope.

@smithfarm
Copy link
Contributor

This PR is now in the integration branch.

@smithfarm
Copy link
Contributor

This passed a rados suite at http://tracker.ceph.com/issues/19009#note-75

@smithfarm smithfarm merged commit d0d9836 into ceph:kraken Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdurgin jdurgin jdurgin approved these changes

Assignees
No one assigned
Labels
bug-fix core needs-qa
Projects
None yet
Milestone
kraken
3 participants
@badone @smithfarm @jdurgin