os/bluestore: cleanup bluestore_types #15680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
reviewed
Jun 14, 2017
src/os/bluestore/bluestore_types.h
Outdated
| p += csum_data.length(); | ||
| } | ||
|
|
||
| if (has_unused()) { |
There was a problem hiding this comment.
I'm not certain this will be faster.. the value in doing a conservative bound is that it mostly compiles down to nothing. Everything up until csum_data.length() is a constant and compiles into a single add instruction. This three conditional branches. And when we encode these the buffer is temporary (used to write to kv db and then thrown away).
There was a problem hiding this comment.
dropped this one for now.
xiexingguo
force-pushed
the
wip-bluestore-20170614
branch
from
a00dc38
to
ee0a1d2
Compare
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
liewegas
approved these changes
Jun 15, 2017
ifed01
reviewed
Jun 15, 2017
src/os/bluestore/bluestore_types.h
Outdated
| @@ -647,41 +649,30 @@ struct bluestore_blob_t { | |||
| b_len += b_off; | |||
| while (b_len) { | |||
| assert(p != extents.end()); | |||
| if (!p->is_valid()) { | |||
| return false; | |||
| if ((require_allocated && !p->is_valid()) || | |||
There was a problem hiding this comment.
replace with if (require_allocated != p->is_valid()) ?
There was a problem hiding this comment.
ahh, that's brilliant
ifed01
approved these changes
Jun 15, 2017
xiexingguo
force-pushed
the
wip-bluestore-20170614
branch
from
ee0a1d2
to
fb34a4b
Compare
…blob_t Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
http://pulpito.ceph.com/kchai-2017-06-15_17:39:27-rados-wip-kefu-testing---basic-smithi/ all issues are known ones. |
|
@tchaikov Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.