osd/ECTransaction: only read partial stripes when below *original* object size #15712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduces http://tracker.ceph.com/issues/19882 Signed-off-by: Sage Weil <sage@redhat.com>
…ject size If we touch a partial stripe that is before the stripe-aligned object size we need to read it in to do a read/modify/write that overalys the new data onto the old. However, if we have two writes, both touching the same stripe but not completely covering it, and that stripe is past the original end of file, there is no old data to read. The previous code was using the projected size to decide whether to do a stripe read, and would end up trying to read data that wasn't there. Fix by basing the stripe read decision on the original object size instead of the projected_size. Fixes: http://tracker.ceph.com/issues/19882 Signed-off-by: Sage Weil <sage@redhat.com>
|
http://pulpito.ceph.com/sage-2017-06-16_19:23:03-rbd:qemu-wip-19882---basic-smithi/ looks good in the rbd/qemu test that was triggering the original bug. still needs normal rados qa and review! |
jdurgin
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/19882