jewel: msg: async messenger bug fix additional backports #15804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
state_buffer is 4096 bytes long, while connect authorizer can be arbitrarily big - an OSD service ticket with lots of per-pool or per-namespace caps is one example. We end up scribbling on invalid memory past the state_buffer and eventually crash. Move authorizer_bl up into connection and read directly into it. Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit f6e7e40)
…SIZE simple messenger's prefetch buffer is ms_tcp_prefetch_max_size. Don't cap it with TCP_PREFETCH_MIN_SIZE in the async messenger. Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit ccc834d) Conflicts: src/msg/async/AsyncConnection.cc (trivial resolution - AsyncConnection::AsyncConnection initializer list is different in jewel)
Signed-off-by: Weibing Zhang <zhangweibing@unitedstack.com> (cherry picked from commit 5ee0b62) Conflicts: src/msg/async/Stack.h (file does not exist in jewel; made the change manually in src/msg/async/AsyncMessenger.h)
smithfarm
changed the title
|
Merged into #13212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18761