New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: rgw add some basic documentation for sync plugins & ES #15849
Conversation
@yehudasa ping |
doc/radosgw/elastic-sync-module.rst
Outdated
.. versionadded:: Kraken | ||
|
||
This sync module writes the metadata from other zones to ElasticSearch. As of | ||
luminous this is json of data fields we currently store in ElasticSearch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fullstop missed at end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but note @amitkumar50 's comments
@yehudasa @amitkumar50 updated |
jenkins test docs |
1 similar comment
jenkins test docs |
Doc build available at http://docs.ceph.com/ceph-prs/15849/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need an index entry
doc/radosgw/elastic-sync-module.rst
Outdated
ElasticSearch tier type configurables | ||
------------------------------------- | ||
|
||
* endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enclose in double backticks
doc/radosgw/elastic-sync-module.rst
Outdated
x-amz-meta-date as type date and x-amz-meta-title as string, you'd do | ||
|
||
:: | ||
POST /mybooks?mdsearch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline
doc/radosgw/elastic-sync-module.rst
Outdated
- max-keys: max number of entries to return | ||
- marker: pagination marker | ||
|
||
expression := [(]<arg> <op> <value> [)][<and|or> ...] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quote
@theanalyst ping |
@theanalyst ping? |
@theanalyst ping |
@yehudasa updated |
jenkins test docs |
doc/radosgw/elastic-sync-module.rst
Outdated
|
||
If empty, all buckets will be indexed. Otherwise, only buckets | ||
specified here will be indexed. It is possible to provide bucket | ||
prefixes (e.g., foo*), or bucket suffixes (e.g., *bar). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning, treated as error:
/home/jenkins-build/build/workspace/ceph-pr-docs/doc/radosgw/elastic-sync-module.rst:66:Inline emphasis start-string without end-string.
Build step 'Execute shell' marked build as failure
@theanalyst you need to escape the asterisk . like
prefixes (e.g., foo\*), or bucket suffixes (e.g., \*bar).
f93f8b8
to
40c9043
Compare
jenkins test docs |
ac13e71
to
f9e6648
Compare
and docs checks are green, did some reorganization by creating another index for sync modules so that future sync modules can be added under the sync-modules tree |
@yehudasa can you take a look again |
jenkins render docs |
Doc render available at http://docs.ceph.com/ceph-prs/15849/ |
@yehudasa is this a good enough first pass at the docs? |
doc/radosgw/sync-modules.rst
Outdated
|
||
The `Multisite`_ functionality of RGW introduced in Jewel allowed the ability to | ||
create multiple zones and mirror data & metadata between them. ``Sync Modules`` | ||
are built atop of the multisite framework that allows for forwarding data & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use and
instead of &
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated all instances
Mostly a rst formatted C-c C-v of Yehuda's mail to the ceph-devel lists Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
Adding a seperate toc under sync modules for elastic, also renamed sync-plugins to sync-modules Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
d65a9cf
to
640b2ae
Compare
jenkins test docs |
Mostly a rst formatted C-c C-v of Yehuda's mail to the ceph-devel lists
Signed-off-by: Abhishek Lekshmanan abhishek@suse.com